2017-12-03 21:15 GMT+01:00 James Darnley <james.darn...@gmail.com>:
> On 2017-12-03 19:30, Martin Vignali wrote: > > libavfilter/x86/vf_threshold.asm | 19 ++++++++++++++----- > > libavfilter/x86/vf_threshold_init.c | 34 ++++++++++++++++++++---------- > ---- > > 2 files changed, 34 insertions(+), 19 deletions(-) > > > > diff --git a/libavfilter/x86/vf_threshold.asm b/libavfilter/x86/vf_ > threshold.asm > > index fb008c376a..7b929c6bd2 100644 > > --- a/libavfilter/x86/vf_threshold.asm > > +++ b/libavfilter/x86/vf_threshold.asm > > @@ -27,14 +27,21 @@ > > SECTION_RODATA > > > > pb_128: times 16 db 128 > > +pb_128_0 : times 16 dw 32768 > > No. Please use db and the values you want. > > I assume this is supposed to be "times 8 db 0, 128". If these are > supposed to be word values then the constant should be named "packed > word". If one were to reuse an existing constant for different word > sizes then it would be acceptable. > > > Thanks for pointing this, I will replace it by pb_128_0 : times 8 db 128, 0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel