2017-11-24 11:55 GMT+01:00 Mark Thompson <s...@jkqxz.net>:
> On 24/11/17 09:37, Karthick J wrote:
>> - s = x264_encoder_headers(x4->enc, &nal, &nnal);
>> + if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) {
>> avctx->extradata = p = av_mallocz(s + AV_INPUT_BUFFER_PADDING_SIZE);
>> if (!p)
>> return AVERROR(ENOMEM);
>>
>
> I think I preferred the version which only wrote the value
> if it isn't already set. If the user specifies a profile then
> it should use that or fail.
The only way to let the user know that another profile was
used (and to fail) is to set the value unconditionally here.
Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
