On 11/20/2017 2:50 PM, Dave Rice wrote: > I am hesitant to see write_colr option removed since the guesswork used here > https://github.com/FFmpeg/FFmpeg/blob/8f4702a93f87f9f76563e80f1ae2141a40029d9d/libavformat/movenc.c#L1747-L1775 > would then be applied to all movs of standard HD and SD size and cause many > ffmpeg outputs to appear differently after the change.
100% agree with this. We *should not* write guessed color information based off of resolution by default. Further, if no color information is present, no colr atom should be written at all, unless it is forced by the user (aka the write_colr option right now). > Could the guesswork here be removed? Or could write_colr be enabled with the > option removed while the guesswork itself has its own option? If the quesswork is removed or put under an option, I still maintain no colr atom should be written if no color information is known. Doing so is just asking for trouble, in my opinion. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
