> Divisions should be avoided in the inner loops as they can be slow done
> The commit message should explain this done That's nothing but the engineering issue: dv stores BE audio, and we're removing byteswap to LE. It seems that this change is meaningless, yes it is, furthermore, the code maybe looks not so obvious for the price of infinitesimal microoptimization (in my implementation, unlike in ffmbc). In fact it just closes the FIXME comment in the code. You're welcome to refuse it, but note, that if you refuse the idea of changing audio endianess to BE in dv, then someone should remove that FIXME comment "maybe we have to admit that DV is a big-endian PCM" (in this case the FIXME is closed too, we just answer "no, we don't have to").
0001-avformat-dv-change-dv-audio-format-endianess-to-BE.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
