Hi, On Mon, Nov 6, 2017 at 8:21 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote:
> 2017-11-06 13:52 GMT+01:00 Ronald S. Bultje <rsbul...@gmail.com>: > > Hi, > > > > On Thu, Oct 12, 2017 at 4:43 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote: > > > >> 2017-10-11 15:53 GMT+02:00 Ashish Pratap Singh <ashk43...@gmail.com>: > >> > >> > Hi, this patch fixes the seg fault which ocuured while running libvmaf > >> > filter with option psnr=1. This also improves libvmaf doc a bit. > >> > >> Please split in two patches. > > > > Split, and pushed. > > + format = (char *) s->desc->name; > > Isn't this cast a bad idea? It's an API thing. We can either strdup(), or use a cast, or have a compiler warning. libvmaf does not modify the argument even if it doesn't use const here. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
