> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Moritz Barsnick > Sent: November 5, 2017 2:11 PM > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > On Sun, Nov 05, 2017 at 02:41:54 +0000, Mironov, Mikhail wrote: > > > > > + { "quality", "", 0, AV_OPT_TYPE_CONST, { .i64 = > > > AMF_VIDEO_ENCODER_HEVC_QUALITY_PRESET_QUALITY }, 0, 0, VE, > > > "quality" }, > > > > > > These are 0, 5, 10. Do the intermediate values work? Should they > > > be exposed? > > > > > Only enum values are supported. I guess they left space for future > extensions. > > What if an unsupported value is passed via > AMF_ASSIGN_PROPERTY_INT64()? > Despite enumerated values, ffmpeg allows to pass numerical values, and you > don't verify that they are only 0, 5, 10.
AMF runtime has strict verification. Error will be returned. > > Moritz > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Thanks, Mikhail _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
