>-------- Original Message -------- >Subject: Re: [FFmpeg-devel] [PATCH] avfilter/zscale: add explanation for error >3074 >Local Time: October 29, 2017 6:50 AM >UTC Time: October 29, 2017 1:50 PM >From: barsn...@gmx.net >To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > >On Sat, Oct 28, 2017 at 20:54:02 -0400, Dxfhgwet wrote: > - av_log(ctx, AV_LOG_ERROR, "code %d: %s\n", err_code, err_msg); > - if (err_code == ZIMG_ERROR_NO_COLORSPACE_CONVERSION) { > - av_log(ctx, AV_LOG_ERROR, "code %d: %s. Try specifying > matrix/transfer/primaries.\n"; > > - } else { > - av_log(ctx, AV_LOG_ERROR, "code %d: %s\n", err_code, err_msg); > > - } > > I didn't try your patch, but I'm extremely sure it doesn't compile. You > forgot a lot of stuff in the first av_log() call line. > > Please, when creating a patch: > - branch locally from master > - do your edits > - try to compile > - fix by editing again > - compile > - test your change > - repeat if necessary > - commit locally > - create a patch from this commit with git format-patch > - submit the patch. > > And please fix your email address when committing. > > Moritz > >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >
Sent with ProtonMail Secure Email.
0001-avfilter-zscale-add-explanation-for-error-3074.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel