Thanks for the review! On Wed, Oct 18, 2017 at 12:26 PM, James Almer <jamr...@gmail.com> wrote: > > Add a line to Changelog about dropping support for OpenJPEG <= 2.0. >
Done. > +enabled libopenjpeg && require_pkg_config libopenjpeg libopenjp2 > openjpeg.h opj_version > > OpenJPEG 2.0.1 ships a pkg-config file, so change the second argument to > "libopenjp2 >= 2.1.0". > Thanks for catching that; I didn't realize 2.0.1 included pkg-config support. Fixed. Aside from that LGTM. It's nice to see all the bloat gone and every > future 2.x version being supported without further changes from now on. Yeah, I look forward to the decreased maintenance costs! Attached is an updated patch with the requested changes to configure and Changelog. I plan on pushing this in a few hours (unless, of course, there are additional critiques).
0001-lavc-drop-support-for-OpenJPEG-1.3-2.0.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel