Hi Moritz,
> On Oct 17, 2017, at 10:40 AM, Moritz Barsnick <barsn...@gmx.net> wrote:
>
> On Tue, Oct 17, 2017 at 09:22:27 -0400, Dave Rice wrote:
>>>> --- a/libavdevice/decklink_dec_c.c
>>>> +++ b/libavdevice/decklink_dec_c.c
>>>> @@ -72,6 +72,7 @@ static const AVOption options[] = {
>>>> { "wallclock", NULL, 0,
>>>> AV_OPT_TYPE_CONST, { .i64 = PTS_SRC_WALLCLOCK}, 0, 0, DEC, "pts_source"},
>>>> { "draw_bars", "draw bars on signal loss" , OFFSET(draw_bars),
>>>> AV_OPT_TYPE_BOOL, { .i64 = 1}, 0, 1, DEC },
>>>> { "queue_size", "input queue buffer size", OFFSET(queue_size),
>>>> AV_OPT_TYPE_INT64, { .i64 = (1024 * 1024 * 1024)}, 0, INT64_MAX, DEC },
>>>> + { "audio_depth", "audio bitdepth (16 or 32)", OFFSET(audio_depth),
>>>> AV_OPT_TYPE_INT, { .i64 = 16}, 16, 32, DEC },
>>>
>>> Use AV_OPT_ ENUM instead.
>>
>> I don't see there to be an AV_OPT_TYPE_ENUM. Could you point out how this
>> works from an example? Alternatively since the decklink sdk only supports 2
>> bit depths (16 and 32), I could use a boolean here if that makes more sense.
>
> I would guess Paul means:
>
> enum audio_bitdepths {
> AUDIO_BITDEPTH_16,
> AUDIO_BITDEPTH_32,
> AUDIO_BITDEPTH_NB
> };
>
> { "audio_depth", "audio bitdepth", OFFSET(audio_depth),
> AV_OPT_TYPE_INT, { .i64 = AUDIO_BITDEPTH_16 }, 0, AUDIO_BITDEPTH_NB-1, DEC,
> "audio_depth" },
> { "16", "16 bits", 0,
> AV_OPT_TYPE_CONST, { .i64 = AUDIO_BITDEPTH_16 }, 0, 0, DEC,
> "audio_depth" },
> { "32", "32 bits", 0,
> AV_OPT_TYPE_CONST, { .i64 = AUDIO_BITDEPTH_32 }, 0, 0, DEC,
> "audio_depth" },
>
> I'm not sure pure digits are accepted as an option strin ("16", "32"), but,
> why shouldn't they.
>
> It may seem like a bit of overkill for two values, but take into
> consideration that you can skip the check "Check audio bit depth option
> for valid values: 16 or 32", but need to map the enums to values
> instead. Or you pre-assign the enums values (AUDIO_BITDEPTH_16 = 16,
> ...), but use some other trick to define the lowest possible value.[*]
> And you can easily add 8 bit or 24 bit support. ;-)
>
> Cheers,
> Moritz
>
> [*]
> enum audio_bitdepths {
> AUDIO_BITDEPTH_LOWEST = 16,
> AUDIO_BITDEPTH_16 = 16,
> AUDIO_BITDEPTH_32 = 32,
> AUDIO_BITDEPTH_NB
> };
>
> { "audio_depth", "audio bitdepth", OFFSET(audio_depth),
> AV_OPT_TYPE_INT, { .i64 = AUDIO_BITDEPTH_16 }, AUDIO_BITDEPTH_LOWEST,
> AUDIO_BITDEPTH_NB-1, DEC, "audio_depth" },
> { "16", "16 bits", 0,
> AV_OPT_TYPE_CONST, { .i64 = AUDIO_BITDEPTH_16 }, 0, 0, DEC, "audio_depth" },
> { "32", "32 bits", 0,
> AV_OPT_TYPE_CONST, { .i64 = AUDIO_BITDEPTH_32 }, 0, 0, DEC, "audio_depth" },
> _______________________________________________
Thanks for pointing me in the right direction. I am attaching an updated patch
below; however, after removing my 16/32 and using the enumeration method (with
the patch below), it accepts any value between AUDIO_BITDEPTH_LOWEST and
AUDIO_BITDEPTH_NB-1 (16 and 32). When I enter any value from 17 through 31 then
the output is still in pcm_s16le, however the resulting audio is slow and
choppy (I'm guessing from the pkt.size line). Am I missing some method to say
that the enumeration list is restrictive?
From 10f3003e8b690bba1a722b615481d80644cdb2c1 Mon Sep 17 00:00:00 2001
From: Dave Rice <d...@dericed.com>
Date: Tue, 17 Oct 2017 10:52:10 -0400
Subject: [PATCH] libavdevice/decklink: 32 bit audio support
---
libavdevice/decklink_common.h | 1 +
libavdevice/decklink_common_c.h | 8 ++++++++
libavdevice/decklink_dec.cpp | 7 ++++---
libavdevice/decklink_dec_c.c | 3 +++
4 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/libavdevice/decklink_common.h b/libavdevice/decklink_common.h
index 6b2525fb53..b6acb01bb9 100644
--- a/libavdevice/decklink_common.h
+++ b/libavdevice/decklink_common.h
@@ -97,6 +97,7 @@ struct decklink_ctx {
int frames_buffer_available_spots;
int channels;
+ int audio_depth;
};
typedef enum { DIRECTION_IN, DIRECTION_OUT} decklink_direction_t;
diff --git a/libavdevice/decklink_common_c.h b/libavdevice/decklink_common_c.h
index 5616ab32f9..cf534c1413 100644
--- a/libavdevice/decklink_common_c.h
+++ b/libavdevice/decklink_common_c.h
@@ -30,6 +30,13 @@ typedef enum DecklinkPtsSource {
PTS_SRC_WALLCLOCK = 4,
} DecklinkPtsSource;
+typedef enum audio_bitdepths {
+ AUDIO_BITDEPTH_LOWEST = 16,
+ AUDIO_BITDEPTH_16 = 16,
+ AUDIO_BITDEPTH_32 = 32,
+ AUDIO_BITDEPTH_NB
+} audio_bitdepths;
+
struct decklink_cctx {
const AVClass *cclass;
@@ -42,6 +49,7 @@ struct decklink_cctx {
double preroll;
int v210;
int audio_channels;
+ int audio_depth;
int duplex_mode;
DecklinkPtsSource audio_pts_source;
DecklinkPtsSource video_pts_source;
diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
index d9ac01ac91..4ecd02b030 100644
--- a/libavdevice/decklink_dec.cpp
+++ b/libavdevice/decklink_dec.cpp
@@ -771,7 +771,7 @@ HRESULT decklink_input_callback::VideoInputFrameArrived(
av_init_packet(&pkt);
//hack among hacks
- pkt.size = audioFrame->GetSampleFrameCount() *
ctx->audio_st->codecpar->channels * (16 / 8);
+ pkt.size = audioFrame->GetSampleFrameCount() *
ctx->audio_st->codecpar->channels * (ctx->audio_depth / 8);
audioFrame->GetBytes(&audioFrameBytes);
audioFrame->GetPacketTime(&audio_pts, ctx->audio_st->time_base.den);
pkt.pts = get_pkt_pts(videoFrame, audioFrame, wallclock,
ctx->audio_pts_source, ctx->audio_st->time_base, &initial_audio_pts);
@@ -854,6 +854,7 @@ av_cold int ff_decklink_read_header(AVFormatContext *avctx)
ctx->audio_pts_source = cctx->audio_pts_source;
ctx->video_pts_source = cctx->video_pts_source;
ctx->draw_bars = cctx->draw_bars;
+ ctx->audio_depth = cctx->audio_depth;
cctx->ctx = ctx;
/* Check audio channel option for valid values: 2, 8 or 16 */
@@ -930,7 +931,7 @@ av_cold int ff_decklink_read_header(AVFormatContext *avctx)
goto error;
}
st->codecpar->codec_type = AVMEDIA_TYPE_AUDIO;
- st->codecpar->codec_id = AV_CODEC_ID_PCM_S16LE;
+ st->codecpar->codec_id = cctx->audio_depth == 32 ?
AV_CODEC_ID_PCM_S32LE : AV_CODEC_ID_PCM_S16LE;
st->codecpar->sample_rate = bmdAudioSampleRate48kHz;
st->codecpar->channels = cctx->audio_channels;
avpriv_set_pts_info(st, 64, 1, 1000000); /* 64 bits pts in us */
@@ -1021,7 +1022,7 @@ av_cold int ff_decklink_read_header(AVFormatContext
*avctx)
}
av_log(avctx, AV_LOG_VERBOSE, "Using %d input audio channels\n",
ctx->audio_st->codecpar->channels);
- result = ctx->dli->EnableAudioInput(bmdAudioSampleRate48kHz,
bmdAudioSampleType16bitInteger, ctx->audio_st->codecpar->channels);
+ result = ctx->dli->EnableAudioInput(bmdAudioSampleRate48kHz,
cctx->audio_depth == 32 ? bmdAudioSampleType32bitInteger :
bmdAudioSampleType16bitInteger, ctx->audio_st->codecpar->channels);
if (result != S_OK) {
av_log(avctx, AV_LOG_ERROR, "Cannot enable audio input\n");
diff --git a/libavdevice/decklink_dec_c.c b/libavdevice/decklink_dec_c.c
index 1127d23ada..e6e1deca65 100644
--- a/libavdevice/decklink_dec_c.c
+++ b/libavdevice/decklink_dec_c.c
@@ -72,6 +72,9 @@ static const AVOption options[] = {
{ "wallclock", NULL, 0,
AV_OPT_TYPE_CONST, { .i64 = PTS_SRC_WALLCLOCK}, 0, 0, DEC, "pts_source"},
{ "draw_bars", "draw bars on signal loss" , OFFSET(draw_bars),
AV_OPT_TYPE_BOOL, { .i64 = 1}, 0, 1, DEC },
{ "queue_size", "input queue buffer size", OFFSET(queue_size),
AV_OPT_TYPE_INT64, { .i64 = (1024 * 1024 * 1024)}, 0, INT64_MAX, DEC },
+ { "audio_depth", "audio bitdepth", OFFSET(audio_depth),
AV_OPT_TYPE_INT, { .i64 = AUDIO_BITDEPTH_16 }, AUDIO_BITDEPTH_LOWEST,
AUDIO_BITDEPTH_NB-1, DEC, "audio_depth" },
+ { "16", "16 bits", 0,
AV_OPT_TYPE_CONST, { .i64 = AUDIO_BITDEPTH_16 }, 0, 0, DEC, "audio_depth" },
+ { "32", "32 bits", 0,
AV_OPT_TYPE_CONST, { .i64 = AUDIO_BITDEPTH_32 }, 0, 0, DEC, "audio_depth" },
{ NULL },
};
--
2.14.2
0001-libavdevice-decklink-32-bit-audio-support.patch
Description: Binary data
Dave Rice
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
