On Mon, Oct 09, 2017 at 09:02:38AM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, Oct 9, 2017 at 6:46 AM, Ivan Kalvachev <ikalvac...@gmail.com> wrote: > > > On 10/9/17, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > > On Sun, Oct 8, 2017 at 6:52 PM, Ivan Kalvachev <ikalvac...@gmail.com> > > wrote: > > > [..] > > > > > > Indentation is off in the second hunk, can you fix that? > > > > You want it 4 spaces to the right > > > > Yes, please. > > BTW, I think it would be better to use "127" number. > > > > I don't really mind either way. The number 128 suggests it may have been > intended as a bitmask. Michael is probably better positioned to comment on > this.
I dont really remember but i think 128 was choosen for ABI compatibility with additions to it from libav. So it shuld no longer matter what values are used on additions [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
