It leaks memory and destroys the dst packet in case of failure, and it ultimately duplicates functionality already existing in the saner av_packet_copy_props().
Signed-off-by: James Almer <jamr...@gmail.com> --- libavcodec/avcodec.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 5c84974e03..bca9f30de3 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4621,7 +4621,10 @@ int av_copy_packet(AVPacket *dst, const AVPacket *src); * Copy packet side data * * @return 0 on success, negative AVERROR on fail + * + * @deprecated Use av_packet_copy_props */ +attribute_deprecated int av_copy_packet_side_data(AVPacket *dst, const AVPacket *src); /** -- 2.14.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
