On Thu, 14 Sep 2017, Jeyapal, Karthick wrote:
Hi Marton,
Thanks a lot for your comments. I have modified the patch as per all your
comments, except the below one.
+ tgt = teletext_data_unit_from_ancillary_packet(buf, buf + 1920, tgt,
cctx->teletext_lines, 0);
this should be
tgt = teletext_data_unit_from_ancillary_packet(buf, buf + len, tgt,
cctx->teletext_lines, 1);
I have modified it as
tgt = teletext_data_unit_from_ancillary_packet(buf, buf + len, tgt,
cctx->teletext_lines, 0);
That was just to be in consistency with the existing code. Because current code
passes allow_multipacket as 0. Let me know if my understanding here is correct.
Shoot, then the original code was incorrect :).
I will take a final look at your patches next week.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel