On 9/10/2017 2:55 PM, Ivan Kalvachev wrote: > On 9/2/17, James Almer <jamr...@gmail.com> wrote: > [...] >> Notes: >> I have no way to test what effect the removal of XVMC truly has. >> The decoders are removed but unlike libav we have hwaccels that are not >> removed by this. Similarly, the pixfmt is also not removed in our case. >> Commit dcc39ee10e82833ce24aa57926c00ffeb1948198 does a thorough removal >> of the remnants of this functionality, but given the above i don't know >> if that applies to us the same way. >> I assume the hwaccels are meant to stay and work after this, so someone >> that knows this code and functionality and has a system where it can be >> tested should ideally look at this. > > I assume that the above commit is from libav? > If so yes, it is the wrong thing to do. > > The code has been reworked so player > uses pix_fmt to select acceleration, > thus no special decoders are needed. > It's like other hwaccel formats. > > If you want I can send a patch that removes the disabled > XvMC functionality and leaves the enabled one. > If you do it instead, be careful, there are both #ifdef and #ifdef !not's, > afair.
I'd very much prefer if you can do it. Adapt the codebase in a way that simply flipping the FF_API_XVMC define from 1 to 0 disables the deprecated code (and potentially enables new code in necessary, like the stuff in pixfmt.h). I have no way to test this functionality so anything i could do would be just a wild guess. Thanks a lot. > > MPlayer has been changed to use the new API years ago, > so it should work (with recompilation, but that's given at API bump). > > I cannot test it ATM, because of HW issues. > I'll try to do this shortly. > > Best Regards. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
