Am 30.08.2017 um 06:19 schrieb Yogender Gupta:
Attached is a CUDA version of the thumbnail filter, this helps accelerate thumbnails generations significantly, when using the GPU pipeline.Regards, Yogender
After having a look at the code:The filter is using a global "CUdeviceptr data;" variable(Which isn't even static). This is generally not acceptable. It makes it impossible to use the filter more than once in parallel. All state should be in the filter context.
Also, the allocated Module and Device-Memory is never freed.uninit should unload the module, free the memory, and do other potentially necessary cleanup.
Otherwise the code seems reasonable to me. Would still like to have someone else review it though.
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
