Le quartidi 14 fructidor, an CCXXV, Ashish Pratap Singh a écrit : > From: Ashish Singh <ashk43...@gmail.com> > > Hi, > This patch changes adm filter from dualinput to framesync2. > > Signed-off-by: Ashish Singh <ashk43...@gmail.com> > --- > Changelog | 1 + > doc/filters.texi | 15 + > libavfilter/Makefile | 1 +
> libavfilter/adm.h | 75 +++++ Can you explain the rationale for a separate header? As far as I can see, you are declaring static variables in it, which is almost always wrong, and a function that is only used once and could be static (and if not, needs the ff_ namespace). Regards, -- Nicolas George
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
