On Mon, Jul 31, 2017 at 02:02:23PM +0200, Nicolas George wrote:
[...]
> static const AVOption haldclut_options[] = {
> - { "shortest", "force termination when the shortest input terminates",
> OFFSET(dinput.shortest), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, FLAGS },
> - { "repeatlast", "continue applying the last clut after eos",
> OFFSET(dinput.repeatlast), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, FLAGS },
> COMMON_OPTIONS
> };
>
> -AVFILTER_DEFINE_CLASS(haldclut);
> +FRAMESYNC_DEFINE_CLASS(haldclut, LUT3DContext, fs);
> So where do these options end up? I'm guessing at the end of the list; if so, please update the documentation: typically, move/remove/factor/rework the shortest/repeatlast part of the options table in the haldclut section (currently there is the option table followed by a sentence about sharing the options with lut3d). Please also document the affected filters in the Changelog. I doubt someone is relying on short-hands for this specific filter and these options given the current unexpected order, but that might not be true for all other filters. Thanks -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
