On Sat, Jul 08, 2017 at 03:38:11PM -0700, Wan-Teh Chang wrote: > Hi Ronald, > > On Sat, Jul 8, 2017 at 2:33 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > > > > I can see the design from the patch. > > > > What's missing is a justification for the downside of the design, which is > > that updates to this variable by the user are no longer propagated to the > > worker threads. > > My justification is the YAGNI principle. > > Although the current code allows the FF_DEBUG_THREADS option to be > toggled dynamically, I believe that was not intended, and I believe > nobody actually does that. In my (admittedly limited) code search, I > only see the FF_DEBUG_THREADS option set via the -debug thread_ops > command-line option.
ffmpeg (the command line tool) allows changing the AVCodecContext->debug value at runtime [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
