Re: [FFmpeg-devel] [PATCHv2 2/2] fate: use do_md5sum instead of the md5 protocol for most md5 fate tests

[Marton Balint]

On Sun, 18 Jun 2017, James Almer wrote:
On 6/17/2017 3:11 PM, Marton Balint wrote:
The md5 protocol has no seek support, but some tests use seeks. This changes
the fate tests to actually create the output files and calculate the md5 on the
written files, which also makes the tests independent of the size of the output
buffers and output buffering in general.

A new md5pipe fate test method is also introduced to keep the old functionality
for tests where using a non-seekable output was intentional, and matroska md5
tests are changed to use that.

Signed-off-by: Marton Balint <c...@passwd.hu>
---
 tests/fate-run.sh                                 | 9 ++++++++-
 tests/fate/filter-audio.mak                       | 4 ++--
 tests/fate/matroska.mak                           | 2 +-
 tests/fate/subtitles.mak                          | 2 +-
 tests/fate/wavpack.mak                            | 4 ++--
 tests/ref/fate/mapchan-6ch-extract-2-downmix-mono | 2 +-
 tests/ref/fate/mapchan-silent-mono                | 2 +-
 tests/ref/fate/mpeg4-bsf-unpack-bframes           | 2 +-
 tests/ref/fate/time_base                          | 2 +-
 tests/ref/fate/v410enc                            | 2 +-
 10 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 931150b5a6..74eca69d4d 100755
--- a/tests/fate-run.sh
+++ b/tests/fate-run.sh
@@ -142,10 +142,17 @@ crc(){
     ffmpeg "$@" -f crc -
 }

-md5(){
+md5pipe(){
     ffmpeg "$@" md5:
 }

+md5(){
+    encfile="${outdir}/${test}.out"
+    cleanfiles=$encfile

Shouldn't this be cleanfiles="$cleanfiles $encfile"? I see some other
functions don't bother to append stuff to cleanfiles and overwrite it
instead, so not sure.

Probably does not matter, maybe appending it is more future proof, if 
somebody wants to invoke it from another function. I changed it locally.


Should be ok otherwise. Thanks for keeping the pipe functionality for
the matroska tests.

Applied, thanks.

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel