On 19/05/17 00:43, Jun Zhao wrote: > > On 2017/5/14 12:26, Jun Zhao wrote: >> V3: - Fix build error with old VAAPI version. >> V2: - Refine the name/value type to mb_rate_control/bool. >> - Only supported GEN9+ (SKL/APL/KBL/...) >> - i965 driver default use frame-level rate control algorithm (generate >> the QP for each frame), >> when enable mb_rate_control, it's will enable the MB-level RC >> algorithm (generate the QP for each MB). >> - enables MB-level bitrate control that generally improves subjective >> visual quality, >> but have negative impact on performance and objective visual quality >> metric. >> > > Ping ?
I fixed the default/enable/disable inconsistency in <https://github.com/01org/intel-vaapi-driver/commit/0dd6ba4e26d3abaa7e66265284ef81c746c13f20>. Using 0/1 as default/on is probably fine, but it doesn't match the statement that it's definitely disabled if the option is zero. (I don't mind which way around that gets fixed.) I tested with this patch and it works fine on a Skylake GT3 (6260U), but it killed the whole machine when enabled on a Skylake GT2 (6300). I haven't yet had chance to investigate that further (rebooting repeatedly is kindof inconvenient), but I will try to do so soon. What platforms have you tested on? - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
