On Fri, 5 May 2017 12:00:02 +0200 Nicolas George <geo...@nsup.org> wrote:
> Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit : > > This should fix Ticket6349. > > Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may > > generate unaligned frame data. > > > > Signed-off-by: Muhammad Faiz <mfc...@gmail.com> > > --- > > libavfilter/avfilter.c | 26 +++++++++++++++++++++++++- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > Sorry, but no. > > According to the C standard and FFmpeg's developer documentation, the > current output of libavfilter is correctly aligned, and libmp3lame is > misbehaving. FFmpeg doesn't follow standard C alignment rules for media data. Please stop bullshitting. Fix the crashes, somehow. Or at least don't prevent others from doing it. > Therefore, you have only two options : > > - fix libmp3lame ; > > - change the documentation to shift the burden elsewhere. > > Note that changing libavfilter is not an option. If you change the > documentation tu put the burden on libavfilter, then this patch can go > in, but the documentation change must come first. > > Note that I will argue for a good documentation change, not something > rushed and inconvenient. > > Regards, > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
