Hi, On Mon, May 1, 2017 at 12:44 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote:
> Hi, > > On Sun, Apr 30, 2017 at 1:16 PM, wm4 <nfx...@googlemail.com> wrote: > >> I think it's probably ok to push your current patch, since the original >> author of the patch who broke this probably won't fix it. > > > I don't like the patch because it essentially duplicates the C > implementation of the DSP function. If we do that here, are we going to do > that everywhere? Will we get 2 DSP functions, aligned and unaligned? I > foresee a mess. > > Michael already said that too, I believe. > Let me expand a little bit further: - if we agree that the API does not require alignment, then we should fix the DSP function (and others in other filters) to allow non-aligned or differently-aligned input data. - if not, then the data alignment should be fixed. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel