On Thu, Apr 06, 2017 at 15:47:58 +0200, Moritz Barsnick wrote:
> On Wed, Apr 05, 2017 at 22:04:01 +0800, Steven Liu wrote:
> > + {"hls_enc", "AES128 encryption support",
> > OFFSET(encrypt), AV_OPT_TYPE_INT, {.i64 = 0}, 0, 1, E},
Furthermore, this looks like a boolean option, -> AV_OPT_TYPE_BOOL,
{"hls_enc", "enable AES128 encryption support"
or something like this.
> > + {"hls_enc_key", "use the specified hex-coded 16byte key to encrypt
> > the segments", OFFSET(key), AV_OPT_TYPE_STRING, .flags = E},
> > + {"hls_enc_key_url", "url to access the key to decrypt the segments",
> > OFFSET(key_url), AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, E},
> > + {"hls_enc_iv", "use the specified hex-coded 16byte initialization
> > vector", OFFSET(iv), AV_OPT_TYPE_STRING, .flags = E},
>
> "use the specified" makes it sound like a boolean option. I suggest:
>
> {"hls_enc_key", "hex-coded 16 byte key to encrypt the segments" [...]
> {"hls_enc_iv", "hex-coded 16 byte initialization vector" [...]
>
> And these should be documented of course.
>
> BTW, your use of spaces in the option declaration is quite ... weird.
> ;-)
>
> Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
