On Mon, Mar 27, 2017 at 04:34:18PM +0200, wm4 wrote: > On Mon, 27 Mar 2017 09:51:55 +0200 > Clément Bœsch <u...@pkh.me> wrote: > > > --- > > libavcodec/avcodec.h | 5 +++++ > > libavcodec/version.h | 3 +++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index 4f3303366f..5c891b531a 100644 > > --- a/libavcodec/avcodec.h > > +++ b/libavcodec/avcodec.h > > @@ -5667,6 +5667,7 @@ attribute_deprecated > > void avcodec_set_dimensions(AVCodecContext *s, int width, int height); > > #endif > > > > +#if FF_API_TAG_STRING > > /** > > * Put a string representing the codec tag codec_tag in buf. > > * > > @@ -5675,8 +5676,12 @@ void avcodec_set_dimensions(AVCodecContext *s, int > > width, int height); > > * @param codec_tag codec tag to assign > > * @return the length of the string that would have been generated if > > * enough space had been available, excluding the trailing null > > + * > > + * @deprecated see av_fourcc_make_string() and av_4cc2str(). > > */ > > +attribute_deprecated > > size_t av_get_codec_tag_string(char *buf, size_t buf_size, unsigned int > > codec_tag); > > +#endif > > > > void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int > > encode); > > > > diff --git a/libavcodec/version.h b/libavcodec/version.h > > index 37defbc365..8dea5cb97b 100644 > > --- a/libavcodec/version.h > > +++ b/libavcodec/version.h > > @@ -235,6 +235,9 @@ > > #ifndef FF_API_MERGE_SD_API > > #define FF_API_MERGE_SD_API (LIBAVCODEC_VERSION_MAJOR < 59) > > #endif > > +#ifndef FF_API_TAG_STRING > > +#define FF_API_TAG_STRING (LIBAVCODEC_VERSION_MAJOR < 59) > > +#endif > > > > > > #endif /* AVCODEC_VERSION_H */ > > To be honest, it's not really necessary to deprecate this. You could > just make it call the "new" code (or the other way around).
Yes, but we would end up with redundant functions with different names, and I think we already have way more than we want to maintain. If I don't deprecate it, I will have to use the new one within the old with, it will just be a wrapper, lavc specific, with not much purpose except being a source of confusion and inconsistency (because it may be used again in our code base). -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
