On Sun, Mar 19, 2017 at 04:35:12PM +0100, Michael Niedermayer wrote:
> On Sun, Mar 19, 2017 at 03:33:41PM +0100, Clément Bœsch wrote:
> > ---
> > libswscale/swscale_internal.h | 20 ++++++--------------
> > 1 file changed, 6 insertions(+), 14 deletions(-)
> >
> > diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h
> > index 6bcb4640ee..b3bb1695fb 100644
> > --- a/libswscale/swscale_internal.h
> > +++ b/libswscale/swscale_internal.h
> > @@ -760,20 +760,12 @@ static av_always_inline int isGray(enum AVPixelFormat
> > pix_fmt)
> > || (x) == AV_PIX_FMT_BGR24 \
> > )
> >
> > -#define isBayer(x) ( \
> > - (x)==AV_PIX_FMT_BAYER_BGGR8 \
> > - || (x)==AV_PIX_FMT_BAYER_BGGR16LE \
> > - || (x)==AV_PIX_FMT_BAYER_BGGR16BE \
> > - || (x)==AV_PIX_FMT_BAYER_RGGB8 \
> > - || (x)==AV_PIX_FMT_BAYER_RGGB16LE \
> > - || (x)==AV_PIX_FMT_BAYER_RGGB16BE \
> > - || (x)==AV_PIX_FMT_BAYER_GBRG8 \
> > - || (x)==AV_PIX_FMT_BAYER_GBRG16LE \
> > - || (x)==AV_PIX_FMT_BAYER_GBRG16BE \
> > - || (x)==AV_PIX_FMT_BAYER_GRBG8 \
> > - || (x)==AV_PIX_FMT_BAYER_GRBG16LE \
> > - || (x)==AV_PIX_FMT_BAYER_GRBG16BE \
> > - )
> > +static av_always_inline int isBayer(enum AVPixelFormat pix_fmt)
> > +{
> > + const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(pix_fmt);
> > + av_assert0(desc);
> > + return !strncmp(desc->name, "bayer_", 6);
>
> iam not sure strncmp() is a good idea speed wise
> In a non-bayer case, the function will return in the worst case after the 2nd character, I have high doubt about this being a speed issue. We can introduce a flag for this, but I don't think it's worth. -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
