Dear Mark, Sorry for the long delay in replying. We have now pushed some changes to our main Turing codec repository to address your comments below. Our custom boost libraries should now be correctly installed so there is no need for preserving any additional Turing build folder. These changes are completely transparent to our ffmpeg patch, which remains valid at v7.
We would appreciate comments on this. Thanks, All the best, ---------------------------------------------------- Saverio Blasi, PhD Senior Research Engineer BBC Research & Development Centre House|56 Wood Lane|London|W12 7SB -----Original Message----- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark Thompson Sent: 28 February 2017 11:02 To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v7] - Added Turing codec interface for ffmpeg On 28/02/17 10:27, Saverio Blasi wrote: > Dear Mark, > > We provide our custom Boost libraries. In our tests we are able to build and > run using just "--enable-gpl --enable-libturing". We would prefer to keep the > pkgconfig file. I am not sure I fully understand what is required to be > changed there (if anything), could you please be a bit more specific? Well, where do those libraries end up? I agree the pkgconfig file is the correct way to do this, but it currently points at the libturing build directory which need not exist when building ffmpeg. You should be able to install the library with some prefix (below using the default /usr/local) and then use it in ffmpeg without any other magic: mkdir libturing-build cd libturing-build cmake ../path/to/libturing/source/ make make install cd .. rm -rf libturing-build mkdir ffmpeg-build cd ffmpeg-build ../path/to/ffmpeg/source/configure --enable-gpl --enable-libturing make ./ffmpeg ... -c:v libturing ... make install ffmpeg ... -c:v libturing ... For me, this sequence currently fails to link for the configure test because the custom boost libraries are not found (were not installed anywhere, as far as I can tell). Have you tried this on a vanilla install of a standard distribution? It sounds like you might have more stuff in your development setup which allows it to work. - Mark > -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: 27 February 2017 11:14 > To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v7] - Added Turing codec interface > for ffmpeg > > On 27/02/17 08:29, Saverio Blasi wrote: >>> Right, I had a bit more of a look at it and was able to "fix" it by adding >>> the boost libraries to the ffmpeg configure line as well. >>> >>> Actually running it it all looks good to me, if as fast as a particularly >>> lethargic snail (like all H.265 encoders targetting quality). >>> >>> valgrind came up with some errors, but they appear to be on the libturing >>> side rather than in the ffmpeg wrapper (i.e. please do fix them, but they >>> don't matter to this patch). >>> >>> Thanks, >>> >>> - Mark >> >> Dear Mark, >> >> Thanks a lot for this, we are very happy to know the patch will be >> integrated. >> Regarding the problems you mention, we will have a look at the output of >> valgrind, and are also working on speeding up the encoder. > > Also the pkgconfig file: > * It refers to the libturing build directory, which need not exist after > installation. > * I think libstdc++ and the boost libraries are always required, not > just when linking statically. (Not sure how this interacts with other > parts, though - it seems to not like the system boost libraries on > Ubuntu 16.04 (1.58): do you need to install your custom boost > libraries as well?) > > It should be possible to build and run with just "--enable-gpl > --enable-libturing" on a clean "make install"ed libturing. > > Thanks, > > - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
