On Wed, Mar 08, 2017 at 01:40:12PM +0100, wm4 wrote: > Side data are separate AVPacket fields for a reason. Merging side data > requires reallocating all packets, is complex, potentially clashes with > "actual" packet data (you could probably come up with PCM data that > looks like merged side data, or such), and could for example cause > trouble to people trying to feed packets with merged side data to > non-libavcodec decoders. > > Disable it by default. > > I do not consider this a real API change, because the AVPacket side data > fields have been part of the API for at least a decade. > > The changed tests either reflect added packet side data, or the changed > packet size due to merged side data removal reducing the packet size. > > ---
> Missing: minor libavformat API bump, maybe a warning in APIchanges this is a ABI change and cannot be done before the next major version bump Applications did not need to preserve side data between layers and this patch would add this requirement The change of the default could be done conditional on the major version or related API/ABI define [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel