On Wed, 22 Feb 2017, Kyle Schwarz wrote:

DeckLink depends on pthread, and is silently disabled if pthread is missing.

Also fixes w32pthreads to support C++.

You should split this into two patches, one the w32pthreads C++ support, other the decklink patch.

Also, I checked the decklink part, and I am a bit confused. I don't see how you ensure that ctx->frames_buffer number of frames are scheduled. Also, are you sure you use the condition/mutexes properly? Your code does not even contains a pthread_mutex_lock call, that seems odd.

What I would expect is to protect the scheduled frame counter with a mutex, and do a cond_signal in the scheduled frame completed callback. Or do you have something else in mind?

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to