Thanks Michael,
Your corrections are appreciated.
On Mon, Feb 13, 2017 at 02:19:45PM +0100, Michael Niedermayer wrote:
> you may want to add yourself to MAINTAINERs (after talking with
> roberto, who i belive has less interrest in cinepak than you do
> nowadays)
Sounds ok for me. Roberto, what do you think (if you read this)?
> > +/* #include "libavutil/avassert.h" */
>
> useless commented out code
I hesitated but left it together with the corresponding commented out
assert() statement to serve as an indication of the validity assumption
we make for pal8. Will change.
> > + av_log(avctx, AV_LOG_ERROR, "Unsupported pixel format %d\n",
> > avctx->pix_fmt);
>
> av_get_pix_fmt_name()
Thanks.
> > @@ -488,4 +1026,6 @@ AVCodec ff_cinepak_decoder = {
> > .close = cinepak_decode_end,
> > .decode = cinepak_decode_frame,
> > .capabilities = AV_CODEC_CAP_DR1,
> > + .pix_fmts = pixfmt_list,
>
> This is possibly unneeded
ok!
Regards,
Rune
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
