Hi Vittorio! thanks for getting back to me.
On Fri, Feb 3, 2017 at 12:57 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > > > Hey Kieran, > I think the code looks fine. I am just wondering if we should also > offer the possibility to set these flags from the standard context > options (-color_trc and others). I'm aware that not all values match > or are valid but maybe a small conversion table or extending the main > table could be a viable approach. Similarly this could be done for the > decoder so that color properties are not lost during a dpx->dpx > conversion maybe. > That seems to be the general consensus from the replies from James Almer and Carl Eugen and it's what i should push towards. I added the new values locally to pixfmt.h. I'm thinking that these could be called in a similar way to the EXR decoder? https://github.com/ FFmpeg/FFmpeg/blob/8a1759ad46f05375c957f33049b459 2befbcb224/libavcodec/exr.c#L1840 In terms of translation tables, could you point me to some simlar code that could serve as a starting point for me? The nearest that made sense to me seems to be these values in vf_colorpsace.c https://github.com/FFmpeg/FFmpeg/blob/master/libavfilter/vf_colorspace.c#L97 ? -kieran _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
