On Sat, Jan 28, 2017 at 08:30:34PM +0100, Moritz Barsnick wrote: > On Sat, Jan 28, 2017 at 11:50:27 +0100, u-9...@aetey.se wrote: > > -// MAX_STRIPS limits the maximum quality you can reach > > -// when you want high quality on high resolutions, > > -// MIN_STRIPS limits the minimum efficiently encodable bit rate > > -// on low resolutions > > -// the numbers are only used for brute force optimization for the first > > frame, > > -// for the following frames they are adaptively readjusted > > -// NOTE the decoder in ffmpeg has its own arbitrary limitation on the > > number > > -// of strips, currently 32 > > +/* MAX_STRIPS limits the maximum quality you can reach */ > > +/* when you want high quality on high resolutions, */ > > +/* MIN_STRIPS limits the minimum efficiently encodable bit rate */ > > +/* on low resolutions */ > > +/* the numbers are only used for brute force optimization for the first > > frame, */ > > +/* for the following frames they are adaptively readjusted */ > > +/* NOTE the decoder in ffmpeg has its own arbitrary limitation on the > > number */ > > +/* of strips, currently 32 */ > > If this is supposed to be cosmetic, it's extremely ugly. Does any other
You have a point. At this place the layout should be changed beyond simply replacing the delimiters. > ffmpeg code use this "style"? :) No, this was not an intended style, just a reflection of the old one. > I think you'd rather use: > > /* > * Extremely long > * multiline comment > * using non-C++ style > * comment delimiters. > */ Yes this is what should have been done, like it looks in other places in the same file. Regards, Rune _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
