On 26.01.2017 02:26, Ronald S. Bultje wrote: > Hi, > > On Wed, Jan 25, 2017 at 8:20 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 07.01.2017 13:44, Ronald S. Bultje wrote: >>> Doesn't this destroy exporting of newly added colorspaces that have no >>> explicit mention yet in libavutil? I'm not 100% sure this is a good >> thing. >> >> Yes. That's how it is already done in libavcodec/h264_ps.c, so it just >> makes handling unknown values consistent. > > > Changing h264_ps.c would also make things consistent.
No, because also libavcodec/options_table.h limits the colorspace to known values. > The question is not whether changing A or B towards the other makes the > combination consistent. The question is which form of consistency is > better... As new values don't get added that often, I don't see a problem with requiring to explicitly add them to libavutil before being able to use them. Best regards, Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
