On Wed, Jan 25, 2017 at 08:33:53PM +0100, Paul Arzelier wrote: > Hi all, > > Would it be possible to continue the discussion began there ? > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-February/168248.html > > The current behavior of FFmpeg when it comes to manage FLAC tags with > both vorbis tags and ID3 tags is to append both, which leads to, for > example, "Artist: Pink Floyd;Pink Floyd" in FFprobe. This is not a > desired output: as the XIPH faq says about FLAC > (https://xiph.org/flac/faq.html): > "FLAC has it's own native tagging system which is identical to that of > Vorbis. They are called alternately "FLAC tags" and "Vorbis comments". > It is the only tagging system required and guaranteed to be supported by > FLAC implementations. > Out of convenience, the reference decoder knows how to skip ID3 tags so > that they don't interfere with decoding. But you should not expect any > tags beside FLAC tags to be supported in applications; some > implementations may not even be able to decode a FLAC file with ID3 tags." > > This issue was also submitted here https://trac.ffmpeg.org/ticket/3799, > but still discuted in the above thread. > Ben Boeckel made the attached patch (which I edited a bit to fit FFmpeg > last version), which fixes the issue. > The problem that remained was that many other files could have > irrelevant id3v2 tags, not only Vorbis/FLAC files, so another more > global patch may be needed to fix that definitely. > > So, do you think Ben's patch could be merged "as-is", or does it only > raise more questions? > > Regards, > Paul >
the attached patch is corrupted: Applying: Fixed behavior when id3 tags were found on FLAC files error: corrupt patch at line 58 Patch failed at 0001 Fixed behavior when id3 tags were found on FLAC files The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
