2017-01-18 19:38 GMT+09:00 Matthieu Bouron <matthieu.bou...@gmail.com>:
> Discards edit list with duration equals to 0 for video streams with only
> one frame and avoid discarding covers art muxed as a single frame video
> stream.
> ---
> Hello,
>
> The following patch discards single edit list with duration equals to 0
> for video streams with only one frame which prevents discarding covers art
> muxed as a single frame video stream.
>
> The patch can be extended to make it always discards single edit list with
> duration equals to 0 (even if the video streams has more than one sample).
> What do you think ?
>
> Matthieu
> ---
> libavformat/mov.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index d1b929174d..88ffd0e5f2 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -2988,6 +2988,17 @@ static void mov_fix_index(MOVContext *mov, AVStream
> *st)
> if (!msc->elst_data || msc->elst_count <= 0 || nb_old <= 0) {
> return;
> }
> +
> + // Discard edit list with duration equals to 0 for video streams with
> only
> + // one frame and avoid discarding covers art muxed as a single frame
> video
> + // stream
> + if (st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO &&
> + msc->chunk_count == 1 &&
> + msc->elst_count == 1 &&
> + msc->elst_data[0].duration == 0) {
>
This can be false positive since segment_duration=0 could be used for
implicit segment_duration when movie fragments. The spec explicitly says
that only when initial movie has no samples but
w16161-14496-12-DefectReport-R4.docx implies that the 14496-12 spec will
also apply it to more generic cases. And why msc->chunk_count == 1? The
chunk_count is the number of chunks but not samples.
> + return;
> + }
> +
> // Clean AVStream from traces of old index
> st->index_entries = NULL;
> st->index_entries_allocated_size = 0;
> --
> 2.11.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
