On Sat, Dec 31, 2016 at 02:29:45PM +0100, Nicolas George wrote: > Le primidi 11 nivôse, an CCXXV, Michael Niedermayer a écrit : > > slightly off topic but ff_update_link_current_pts() has no > > documentation in the header > > I also noticed it. Also, it is now only used in avfilter.c, so it could > be made static. I will have to address it when I get to maintaining a > priority queue of filters that are ready and deprecating > avfilter_graph_request_oldest(), since they are related > (ff_update_link_current_pts() maintains a heap of sink links by > timestamp). > > > also the commit message is a bit terse, why is it moved > > does this add or remove calls to it in some codepathes ? > > I reworded it as: > > lavfi: move ff_update_link_current_pts() into the utility functions. > > It does not change anything for the existing filters and makes > better code fatrorization when future code will use the utility > functions. > > My reason to have it in a separate commit is to be able to run FATE > before and after the change to check it did not break anything.
LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct answer.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
