On Fri, Dec 16, 2016 at 09:19:00AM +0100, Paul B Mahol wrote: > On 12/16/16, Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Thu, Dec 15, 2016 at 10:39:37PM +0100, Paul B Mahol wrote: > >> Hi, > >> > >> patch attached > > > >> vf_ssim.c | 130 > >> ++++++++++++++++++++++++++++++++++++++++++++++++----- > >> x86/vf_ssim_init.c | 2 > >> 2 files changed, 120 insertions(+), 12 deletions(-) > >> 7b60c3cadb5319fb93f3875942b50ab9f9b89e1e > >> 0001-avfilter-vf_ssim-add-9-and-10-bit-depth-suppport.patch > >> From ebf2f89fd191ed661c503726106e46b7c81d6cba Mon Sep 17 00:00:00 2001 > >> From: Paul B Mahol <one...@gmail.com> > >> Date: Thu, 15 Dec 2016 22:33:42 +0100 > >> Subject: [PATCH] avfilter/vf_ssim: add 9 and 10 bit depth suppport > >> > >> Signed-off-by: Paul B Mahol <one...@gmail.com> > >> --- > >> libavfilter/vf_ssim.c | 130 > >> +++++++++++++++++++++++++++++++++++++---- > >> libavfilter/x86/vf_ssim_init.c | 2 +- > >> 2 files changed, 120 insertions(+), 12 deletions(-) > > > > this produces some build warnings > > > > CC libavfilter/vf_ssim.o > > libavfilter/vf_ssim.c: In function ‘ssim_4x4xn_16bit’: > > libavfilter/vf_ssim.c:100:21: warning: ‘main’ is usually a function > > [-Wmain] > > libavfilter/vf_ssim.c: In function ‘ssim_plane_16bit’: > > libavfilter/vf_ssim.c:246:9: warning: passing argument 1 of > > ‘ssim_endn_16bit’ from incompatible pointer type [enabled by default] > > libavfilter/vf_ssim.c:195:14: note: expected ‘const int64_t (*)[4]’ but > > argument is of type ‘int64_t (*)[4]’ > > libavfilter/vf_ssim.c:246:9: warning: passing argument 2 of > > ‘ssim_endn_16bit’ from incompatible pointer type [enabled by default] > > libavfilter/vf_ssim.c:195:14: note: expected ‘const int64_t (*)[4]’ but > > argument is of type ‘int64_t (*)[4]’ > > CC libavfilter/x86/vf_ssim_init.o > > libavfilter/x86/vf_ssim_init.c: In function ‘ff_ssim_init_x86’: > > libavfilter/x86/vf_ssim_init.c:40:28: warning: assignment from incompatible > > pointer type [enabled by default] > > > > [...] > > -- > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > > > I know you won't believe me, but the highest form of Human Excellence is > > to question oneself and others. -- Socrates > > > > Better patch attached.
fixes all warnings, thx i dont see any obvious issues in the patch but you know that code better than i do ... thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
