On Tue, Dec 6, 2016 at 11:06 AM, James Almer <jamr...@gmail.com> wrote: > On 11/30/2016 9:12 PM, James Almer wrote: >> On 11/30/2016 8:36 PM, Vittorio Giovara wrote: >>> This implements Spherical Video V1 and V2, as described in the >>> spatial-media collection by Google. >>> >>> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> >>> --- >>> This addresses all comments from James. >>> Vittorio >> >> LGTM, at least the V2 part. Seems to follow the spec right now. >> Will trust you on the V1 part :P.
Hopefully V1 is going to disappear soon. Thanks for the review, I've sent a minor documentation update which reflects the latest change to the specification, I hope that is fine too. >> I have written a Matroska implementation of this spec, for that >> matter. Will send it after this patchset is committed. Oh cool, do you have or need a file to test (and/or add a fate)? -- Vittorio _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
