On Fri, Dec 02, 2016 at 05:05:29PM +0100, Timo Rothenpieler wrote: > > Is it just me or is this completely inconsistent? > > the codec id told to the user is h264 while we internally use a > > mpeg2 decoder to analyze it ? > > > > If its h264 (as forced by the user) we should use a h264 decoder > > to internally analyze it > > > > Yes, something is very wrong here. > I also wasn't able to reproduce this with any self made sample. Only the > one from Ticket 5985 makes it crash for me. In two separate ways even. > In one case, the avctx->codec is NULL, because there are unknown codecs > in that sample, and in other cases the codecs mismatch. > > I don't have time to take an in depth look at what is going on there, so > for now I decided to harden it against crashes, which is probably a good > idea in any case.
I dont think its a good idea to leave the inconsistency [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel