On Fri, Dec 02, 2016 at 12:44:41AM +0100, Andreas Cadhalpun wrote: > On 01.12.2016 01:34, Michael Niedermayer wrote: > > On Thu, Dec 01, 2016 at 12:22:50AM +0100, Andreas Cadhalpun wrote: > >> @@ -6381,6 +6410,11 @@ for thread in $THREADS_LIST; do > >> fi > >> done > >> > >> +# Check if requested libraries were found. > >> +for lib in $AUTODETECT_LIBS; do > >> + requested $lib && ! enabled $lib && die "ERROR: $lib requested but > >> not found"; > >> +done > > > > This must be after check_deps as that can disable vaapi > > I agree, but... > > > unless i miss something > > ...it is already after check_deps. ;) >
> > also in the same light i think things like: > > > > enabled vaapi && > > check_lib va/va.h vaInitialize -lva || > > disable vaapi > > > > should disable vaapi through having a entry in vaapi_deps= ... > > There is already va_va_h in vaapi_deps and I'm not sure, what else > you'd like to have there. i see a "disable vaapi" here but that should be done by the dependency or why is it done here ? > However, it seems independent of this patch. yes iam ok with the patch if other are and its tested thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB During times of universal deceit, telling the truth becomes a revolutionary act. -- George Orwell
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
