On Tue, Nov 29, 2016 at 10:53:15AM -0500, Vittorio Giovara wrote: > On Tue, Nov 29, 2016 at 7:20 AM, Michael Niedermayer > <mich...@niedermayer.cc> wrote: > > On Mon, Nov 28, 2016 at 10:03:37PM -0500, Vittorio Giovara wrote: > >> On Mon, Nov 28, 2016 at 9:06 PM, Michael Niedermayer > >> <mich...@niedermayer.cc> wrote: > >> > On Tue, Nov 08, 2016 at 05:03:27PM -0500, Vittorio Giovara wrote: > >> >> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> > >> >> --- > >> >> Applied review. > >> >> Please CC. > >> >> Vittorio > >> >> > >> >> libavcodec/hevc.c | 10 ++++++++++ > >> >> libavformat/mov.c | 4 ---- > >> > > >> > please split this in 2 patches, the libavcodec one probably should > >> > also have its version bumped as apps might want to depend on > >> > a libavcodec with that feature > >> > >> ok for the version bumb, why splitting it 2 patches though? > > > > making changes to 2 libs at the same time can mask bugs because > > you cannot checkout and test the intermediate but in distributions > > users can end up with one lib updated and the other not (within what > > the dependancies and versions allow) > > So i always suggest spliting non cosmetic changes into a patch per lib > > unless i miss/forget > > Well yes, but the changes in lavf only drop a log line, which is > useless because of this patch, so imo it makes sense to keep them in > the same diff. I'll split it if you insist though.
its ok to keep it on one patch if you prefer [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
