On 11/24/2016 8:13 PM, Hendrik Leppkes wrote: > On Tue, Nov 22, 2016 at 3:13 AM, James Almer <jamr...@gmail.com> wrote: >> Fixes ticket #5973 >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> Maybe init() should propagate the extradata down the filter chain instead >> of this, since if an aac stream has extradata then it means that it's an >> ASC stream. Neither ADTS or LATM use extradata. >> >> What's preferred? >> > > Forwarding the extradata right away in init is probably better. As you > say any of the other alternatives don't use any. > Could try to parse it to make sure its valid, and not forwarding > garbage, if you really care.
Sure, will send a new patch to do that. Thanks. > > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
