On Mon, Nov 14, 2016 at 12:21 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-11-14 0:11 GMT+01:00 Hendrik Leppkes <h.lepp...@gmail.com>: >>>> That has proven to be problematic before, between merges >>>> adding fields at the wrong offset by accident, >>> >>> IIRC, you are mistaken, we only had that kind of issue about >>> public fields. >> >> No, this happened in 3.1 with "private" fields in public headers (in >> lavfi among other things), which is what sparked the discussion to get >> rid of all these in the future, either by making them proper public if >> appropriate, or hiding them entirely from the publics eye - and the >> existing concept we have for that is *Internal contexts. > > Could you point me to this discussion? >
It was on IRC shortly after the 3.1 release when we were fixing the ABI "breakage" of some private fields that affected some downstreams. Probably 06/29 and surrounding days. This is in two parts, deprecate (and eventually remove) the getter/setter functions which only existed to keep ABI compat with libav, which we discontinued, so we can allow direct access to these fields again. And in the same process, check which fields marked as "private" or "no direct access" might be better hidden from the user entirely, or promoted to proper public fields with a stable ABI guarantee. - Hendrik _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
