On Mon, Sep 19, 2016 at 04:25:24PM +0300, Erkki Seppälä wrote: > when the option "brand" is used. This allows custom brands to end up in > the compatible brands as well. > > Signed-off-by: Erkki Seppälä <erkki.seppala....@nokia.com> > Signed-off-by: OZOPlayer <oz...@nokia.com> > --- > libavformat/movenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 525d103..571c2a7 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -4210,6 +4210,8 @@ static int mov_write_ftyp_tag(AVIOContext *pb, > AVFormatContext *s) > > avio_wb32(pb, minor); > > + if (mov->mode == MODE_MP4 && mov->major_brand) > + ffio_wfourcc(pb, mov->major_brand); /* write major brand as a > compatible brand */
missing length check, this would be writing uninitialized bytes if it was nt 4 bytes long [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
