On 10/25/16, Carl Eugen Hoyos <ceffm...@gmail.com> wrote:
> 2016-10-25 13:01 GMT+02:00 Paul B Mahol <one...@gmail.com>:
>> On 10/25/16, Carl Eugen Hoyos <ceho...@ag.or.at> wrote:
>>> Hi!
>>>
>>> Attached patch may fix an issue reported on the gusari forum.
>
>> Please clearly explain what is actual problem and what this patch
>> actually solves. I do not have time of all existence to search forums
>> on internet.
>
> Currently, ff_put_bmp_header() always writes "24" as biBitCount
> for utvideo because bits_per_coded_sample is never set by the
> encoder. Attached patch fixes the value of bits_per_coded_sample
> for rgba utvideo.
> (I do not know if the patch fixes an actual issue reported by a
> user and I cannot test.)
>
> Carl Eugen
>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Please put above explanation in commit log. Patch lgtm.

Have a nice day.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to