2016-10-09 20:09 GMT+08:00 Steven Liu <lingjiujia...@gmail.com>: > > > 2016-10-09 19:54 GMT+08:00 Michael Niedermayer <mich...@niedermayer.cc>: > >> On Sun, Oct 09, 2016 at 07:18:48PM +0800, Steven Liu wrote: >> > 2016-10-09 19:00 GMT+08:00 Michael Niedermayer <mich...@niedermayer.cc >> >: >> > >> > > On Sat, Oct 08, 2016 at 03:35:02PM +0800, Steven Liu wrote: >> > > > >> > > >> > > > udp.c | 19 ++++++++++++++++++- >> > > > version.h | 3 +++ >> > > > 2 files changed, 21 insertions(+), 1 deletion(-) >> > > > bf9c64b4a0fd9a1d998c11376c5c5c2a90389caf >> 0001-avformat-udp-deprecate- >> > > local_port-option.patch >> > > > From 16a41c1e76fef082bf2a7238f940968238f573d5 Mon Sep 17 00:00:00 >> 2001 >> > > > From: Steven Liu <lingjiujia...@gmail.com> >> > > > Date: Sat, 8 Oct 2016 15:31:25 +0800 >> > > > Subject: [PATCH] avformat/udp: deprecate local_port option >> > > >> > > patchwork fails to pick up your recent patches >> > > see: https://patchwork.ffmpeg.org/project/ffmpeg/list/? >> > > submitter=23&state=%2A&archive=both >> > > >> > > probably because "Type: application/octet-stream" >> > > (this is the wrong mime type for patches) >> > > >> > > [...] >> > > >> > > -- >> > > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7 >> 87040B0FAB >> > > >> > > Rewriting code that is poorly written but fully understood is good. >> > > Rewriting code that one doesnt understand is a sign that one is less >> smart >> > > then the original author, trying to rewrite it will not make it >> better. >> > > >> > > _______________________________________________ >> > > ffmpeg-devel mailing list >> > > ffmpeg-devel@ffmpeg.org >> > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > > >> > > >> > >> > paste patch context to test patchwork pick up. >> > >> > >> > Signed-off-by: Steven Liu <lingjiujia...@gmail.com> >> > --- >> > libavformat/udp.c | 19 ++++++++++++++++++- >> > libavformat/version.h | 3 +++ >> > 2 files changed, 21 insertions(+), 1 deletion(-) >> > >> > diff --git a/libavformat/udp.c b/libavformat/udp.c >> > index 3835f98..fd400c6 100644 >> > --- a/libavformat/udp.c >> > +++ b/libavformat/udp.c >> > @@ -86,6 +86,9 @@ typedef struct UDPContext { >> > int pkt_size; >> > int is_multicast; >> > int is_broadcast; >> > +#if FF_API_UDP_LOCAL_PORT >> > + int local_port_deprecated; >> > +#endif >> > int local_port; >> > int reuse_socket; >> > int overrun_nonfatal; >> > @@ -123,7 +126,9 @@ static const AVOption options[] = { >> > { "bitrate", "Bits to send per second", >> > OFFSET(bitrate), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, >> > INT64_MAX, .flags = E }, >> > { "burst_bits", "Max length of bursts in bits (when using >> > bitrate)", OFFSET(burst_bits), AV_OPT_TYPE_INT64, { .i64 = 0 }, >> 0, >> > INT64_MAX, .flags = E }, >> > { "localport", "Local port", >> > OFFSET(local_port), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, >> INT_MAX, >> > D|E }, >> >> this is corruptd by newlines >> > > I promise there have no newline, the captrue picture is atteched. > >> >> [...] >> -- >> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB >> >> I have often repented speaking, but never of holding my tongue. >> -- Xenocrates >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> > I have a question:
the patch is maked by command "git format-patch -s -1", but the patchwork can not pick up it， my git version is: localhost:ffmpeg StevenLiu$ git version git version 2.8.4 (Apple Git-73) localhost:ffmpeg StevenLiu$ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
