For the gapless playback: I can hack so that we have monotonically increasing timestamps for the audio , when demuxing . Basically going back in the index and setting correct timestamps for the discarded packets. But, as pointed out in the IRC channel, I modify skip_samples field too in the mov_fix_index function, which might be harder to fix. I want to know if we need to have skip_samples field as exactly the same as before , for the gapless decoding by "external decoder wrappers " to work.
On Mon, Sep 19, 2016 at 12:02 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Sep 19, 2016 at 11:08:30AM -0700, Sasi Inguva wrote: > > Thanks Michael, for the assiduous review. We caught 2-3 audio decoding > bugs > > because of it, and implemented basic seek functionality. > > It seems this causes a regression > durandal117 and wm4 on IRC pointed out that the change to the gapless > fate test seems wrong > > [...] > > > > tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 8 +- > > > > tests/ref/fate/gaplessenc-pcm-to-mov-aac | 8 +- > > Can you look at this ? > > Thanks > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > When the tyrant has disposed of foreign enemies by conquest or treaty, and > there is nothing more to fear from them, then he is always stirring up > some war or other, in order that the people may require a leader. -- Plato > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
