On Tue, Sep 13, 2016 at 02:56:16PM -0300, James Almer wrote:
> On 9/13/2016 2:42 PM, Clément Bœsch wrote:
> > On Tue, Sep 13, 2016 at 02:36:46PM -0300, James Almer wrote:
> > [...]
> >>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> >>> index 74915a1..389d985 100644
> >>> --- a/libavformat/avformat.h
> >>> +++ b/libavformat/avformat.h
> >>> @@ -2894,6 +2894,27 @@ int av_apply_bitstream_filters(AVCodecContext
> >>> *codec, AVPacket *pkt,
> >>> AVBitStreamFilterContext *bsfc);
> >>> #endif
> >>>
> >>> +enum AVTimebaseCopyFrom {
> >>
> >> AVTimebaseSource? CopySource? CopyFrom sounds kinda weird.
> >>
> >
> > Sure, anything you prefer
> >
> >>> + AVFMT_TBCF_AUTO = -1,
> >>> + AVFMT_TBCF_DECODER,
> >>> + AVFMT_TBCF_DEMUXER,
> >>> + AVFMT_TBCF_R_FRAMERATE,
> >>
> >> What's the deal with r_frame_rate anyway? There's an FF_API define for it
> >> as
> >> if it were deprecated, yet the field is not tagged as such and said define
> >> is
> >> not wrapping all its uses.
> >>
> >
> > I have no idea. Should I drop it from the public enum and keep the ==2
> > hack in the function until we find a clean way?
>
> You could also wrap the enum inside a FF_API_R_FRAME_RATE check, i guess.
> But in any case i was just wondering why the field (or the functionality)
> is supposedly deprecated but not really. Your code is fine as is.
>
Applied with FF_API_R_FRAME_RATE check and AVTimebaseSource
Thanks,
--
Clément B.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
