On Mon, Sep 12, 2016 at 09:02:25PM -0500, Rodger Combs wrote:
>
> > On Sep 10, 2016, at 05:10, Michael Niedermayer <mich...@niedermayer.cc>
> > wrote:
> >
> > On Fri, Sep 09, 2016 at 08:06:39PM -0500, Rodger Combs wrote:
> >> I'm not entirely sure why found_hdlr_mdta existed to begin with, so cc-ing
> >> Tinglin Liu (who originally wrote the patch) and Derek Buitenhuis (who
> >> signed
> >> off on it) hoping for some background. If these checks actually do have a
> >> purpose, then the `type == MKTAG('m','d','t','a')` check should be moved
> >> to before the `c->fc->nb_streams < 1` check instead of inside it.
> >> ---
> >> libavformat/isom.h | 1 -
> >> libavformat/mov.c | 10 +++-------
> >> 2 files changed, 3 insertions(+), 8 deletions(-)
> >
> > This seems to change
> > "handler_name : sound handler" to
> > "handler_name : ilst handler"
> >
> > for http://samples.ffmpeg.org/MPEG-4/replaygain/sample.mp4
> >
> > is that intended ?
>
> Hmm, this looks like a consequence of the `handler_name` key being provided
> in multiple places on the same track, but I'm not sure `handler_name` is ever
> meaningful to the consumer to begin with, so I'm not sure if this matters?no idea iam not objecting to the patch, just pointing out what i found [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
