On 08/23/2016 06:20 PM, Yusuke Nakamura wrote:
- avio_wb16(pb, 2);
+ avio_wb16(pb, track->par->channels);
No. the ChannelCount field is templated. It may be fixed to 2 by derived
specs or the specs of codec encapsulations. I mean the current
implemetation is wrong, and your implementation is also wrong. For
instance, ChannelCount of AC-3 in ISOBMFF is always hardcoded to 2 even if
5.1ch. This field is basically not useful for ISOBMFF and the actual
channels shall be referred to Codec specific info.
It seems the part of the standard didn't give the full view on the
matter. This patch can be dropped.
Thanks for the review!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
