Hi, On Tue, Jul 26, 2016 at 3:30 PM, Davinder Singh <ds.mud...@gmail.com> wrote:
> hi > > On Mon, Jul 25, 2016 at 9:55 PM Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > > Hi, > > > > On Mon, Jul 25, 2016 at 5:39 AM, Michael Niedermayer > > <mich...@niedermayer.cc > > > wrote: > > > > > On Mon, Jul 25, 2016 at 04:05:54AM +0000, Davinder Singh wrote: > > > > https://github.com/dsmudhar/FFmpeg/commits/dev > > > > > > So, correct me if I'm wrong, but it seems the complete ME code currently > > lives inside the filter. I wonder if that is the best way forward. I > > thought the idea was to split out the ME code into its own module and > share > > it between various filters and the relevant encoders without a strict > > dependency on avfilter/avcodec, or more specifically, AVCodecContext or > > anything like that? > > > > Ronald > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > The code is almost ready to be shared, I just didn't move that yet. That > makes changes difficult. mInterpolate will use those functions (which are > currently in mEstimate) to find true motion. My plan is to move that code > out of mEstimate to say, libavfilter/motion_estimation.c and can be shared > between multiple filters. Since that is general ME, I think it can be used > with encoding (with some changes). So, should I move it to libavutil > instead? I have no strong opinion on where it lives, I'd say libavcodec since we already have some lavfilters depending on lavcodec, but if you prefer lavutil that's fine also. As long as the code itself is shared in the final product, it's good with me. Thanks! Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel