On Thu, Jul 14, 2016 at 04:26:09PM -0400, compn wrote: > On Wed, 13 Jul 2016 17:06:43 +0200 (CEST) > g...@videolan.org (Vittorio Giovara) wrote: > > > ffmpeg | branch: master | Vittorio Giovara > > <vittorio.giov...@gmail.com> | Thu Jun 9 18:55:19 2016 -0400| > > [846a3e78a535f05ee61bb23a160f3378f041f751] | committer: Vittorio > > Giovara > > > > mov: Support prores with multiple stsd > > > > This function needs to return false, or data in the additional tables > > will be skipped, and the decoder will not be able to decode frames > > associated with them. > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=846a3e78a535f05ee61bb23a160f3378f041f751 > > --- > > > > libavformat/mov.c | 2 ++ > > > + // prores is allowed to have differing data format and > > codec tag > > + codec_tag != AV_RL32("apcn") && codec_tag != > > AV_RL32("apch") && (c->fc->video_codec_id ? video_codec_id != > > arent there more than just apch / apcn isom tags? > > libavformat/isom.c lists a few: > > { AV_CODEC_ID_PRORES, MKTAG('a', 'p', 'c', 'h') }, /* Apple ProRes 422 High > Quality */ > { AV_CODEC_ID_PRORES, MKTAG('a', 'p', 'c', 'n') }, /* Apple ProRes 422 > Standard Definition */ > { AV_CODEC_ID_PRORES, MKTAG('a', 'p', 'c', 's') }, /* Apple ProRes 422 LT > */ > { AV_CODEC_ID_PRORES, MKTAG('a', 'p', 'c', 'o') }, /* Apple ProRes 422 > Proxy */ > { AV_CODEC_ID_PRORES, MKTAG('a', 'p', '4', 'h') }, /* Apple ProRes 4444 */ > { AV_CODEC_ID_PRORES, MKTAG('a', 'p', '4', 'x') }, /* Apple ProRes 4444 > XQ */ > > > shouldnt these other 4 tags also be added?
do you or others have samples where this makes a difference ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
